Everyone dreads “Design by committee”. Someone proofing your work might be a threat to creativity. But approaching digital design as a sole creative genius simply doesn’t work. Ida shares what she’s learned about collaboration from developers.
12. “Code review is systematic examination […] of
computer source code. It is intended to find mistakes
overlooked in software development, improving the
overall quality of software. Reviews are done in
various forms such as pair programming, informal
walkthroughs, and formal inspections
Wikipedia
14. Pull request submitted by
ingvilin
#423 Add onboarding status
To keep track of the
onboarding progress, a
default onboarding progress
object is added to the user’s
metadata on completing the
sign-up process.
ingvilin requested a review
from daginge
23. “Code reviews set the tone for the entire
company that everything we do should be
open to scrutiny from others, and that such
scrutiny should be a welcome part of your
workflow rather than viewed as threatening.
Bruce Johnson, co-founder of Full Story
24. “Code reviews set the tone for the entire
company that everything we do should be
open to scrutiny from others, and that such
scrutiny should be a welcome part of your
workflow rather than viewed as threatening.
Me
32. Principle #5
Don’t forget to
praise the good parts!
What’s clever, creative, solid, original, funny, nice, etc?
33. Review principles
1. Critique the work, not the author.
2. Be critical, but remain affable and curious.
3. Differentiate between a) suggestions,
b) requirements, and c) points that need discussion
or clarification.
4. Move discussions from text to face-to-face.
5. Don’t forget to praise the good parts!
57. Review walkthroughs
• Walkthrough is done together
• One person in charge of reviewing and documenting
• Choose a format that gives as much context as possible
• The idea is to identify issues, not necessarily solve them