29/11/2018 https://www.meetup.com/pt-BR/KWAN-SmallTalks/events/256541789/

1. THAMARA HESSEL
I’m a coder

2. CODE REVIEW
Effective

3. Code review is...
A formal assessment of code with the intention to check the changes …

4. Why do I need to do it?

5. What exactly am I looking for?
Why do I need to do it?

6. Why do I need to do it?
Do I enjoy getting feedback?
What exactly am I looking for?

7. 5 Stages about code review

8. Disillusioned
Do not see the value or real importance and is totally or partially unhappy with codebase

9. Afraid
Criticizes or dislikes but understands the importance

10. Observer
Not criticize or dislike, understands the importance but isn’t totally satisfied.

11. Optimist
Understands the importance, is partially satisfied but doesn’t feel it’s learning

12. Satisfied
Understands the importance, is partially or totally satisfied and feel it’s learning

13. How to find this happiness?

14. How to find this happiness?
Effective code review

15. How to find this happiness?
Effective code review
What does that mean?

16. Effective code review
Discipline to follow the steps

17. Effective code review
1. Fully understand the 'why', 'when' and 'what' of receiving or doing a
code review.

18. Why when what

19. Why when what

20. Why when what
Why do I need to do it?
Because …
❏I care
❏I want to be satisfied
❏I like my colleagues
❏I am a professional

21. Why when what

22. Why when what

23. Why when what
When do I need to do it?
Early as possible because …
❏ I want to help
❏ I know that code rots
❏ I don’t like to do repeated work
❏ I have knowledge to pass
❏ I have a strong opinion about how it should be done
❏ I am new in the project
❏ I want to learn

24. Why when what

25. Why when what

26. Why when what

27. Why when what

28. Why when what

29. Why when what

30. Why when what
What exactly am I looking for?
As machine ...
❏ code standards/style
❏ tests (units, functional, end2end)
❏ acceptance criteria
❏ etc ...
As human ...
❏ readable code
❏ design & architecture
❏ solution achieved

31. Why when what

32. Why when what

34. OMG!!!

35. Why when what
Style
Find Bugs
Design Discussion
Correct Solution
Mental Alignment

36. Why when what
Why...
Style
Find Bugs
Design Discussion
Correct Solution
Mental Alignment

37. Why when what
Why...
...What
Style
Find Bugs
Design Discussion
Correct Solution
Mental Alignment

38. Why when what
Why...
...What
When…
automated tools - FAST
Style
Find Bugs
Design Discussion
Correct Solution
Mental Alignment

39. Why when what
Why...
...What
When…
automated tools - FAST
...When
peer review - SLOW
Style
Find Bugs
Design Discussion
Correct Solution
Mental Alignment

40. Effective code review
1. Fully understand the 'why', 'when' and 'what' of receiving or doing a
code review.
1. 10 commandments of Egoless Programming

41. 10 commandments of
Egoless Programming
Egoless programming is a style of computer programming in which personal factors are minimized so that quality
may be improved. The cooperative methods suggested.

42. 10 commandments of
Egoless Programming
1. Understand and accept that you will make mistakes.

43. 2. You are not your code.
10 commandments of
Egoless Programming

44. 10 commandments of
Egoless Programming
3. No matter how much “karate” you know, someone else will always know
more.

45. 4. Don’t rewrite code without consultation.
10 commandments of
Egoless Programming

46. 5. Treat people who know less than you with respect and patience.
10 commandments of
Egoless Programming

47. 6. The only constant in the world is change.
10 commandments of
Egoless Programming

48. 7. The only true authority comes from knowledge, not from position.
10 commandments of
Egoless Programming

49. 8. Fight for what you believe, but gracefully accept defeat.
10 commandments of
Egoless Programming

50. 9. Don’t be “the guy in the room.”
10 commandments of
Egoless Programming

51. 10 commandments of
Egoless Programming
10. Critique code instead of people — be kind to the coder, not to the code.

52. Effective code review
1. Fully understand the 'why', 'when' and 'what' of receiving or doing a
code review.
1. 10 commandments of Egoless Programming
1. Remember “You only live with the problems you have ‘accepted’ ”

53. Code review is...
and a great way to learn collaboratively
A formal assessment of code with the intention to check the changes ...

54. 54
Books

56. Q&A
Send me an email
thamara.hessel@gmail.com

57. 57

58. 58
Links
https://atlas.mindmup.com/thamarahessel/code_review/index.html
https://atlas.mindmup.com/thamarahessel/code_review/archive.zip
https://www.youtube.com/watch?v=sSm2dRarhPo
https://www.youtube.com/watch?v=EyL7mqwpZhk
https://www.youtube.com/watch?v=fatTnX8_ZRk
https://www.processimpact.com/articles/humanizing_reviews.pdf
https://medium.com/programming-philosophy/the-10-commandments-of-egoless-programming-89d79b9d73eb
http://webcache.googleusercontent.com/search?q=cache:FkywG-
DRqAsJ:assets.en.oreilly.com/1/event/80/Effective%2520Code%2520Review%2520Presentation.ppt+&cd=3&hl=en&ct=clnk&gl=pt
http://blakesmith.me/2015/02/09/code-review-essentials-for-software-teams.html
https://blog.submain.com/dont-need-code-review-template/
https://hackernoon.com/effective-code-reviews-e8ac466b9a2e
https://nyu-cds.github.io/effective-code-reviews/02-best-practices/
https://medium.com/palantir/code-review-best-practices-19e02780015f
https://blog.digitalocean.com/how-to-conduct-effective-code-reviews/
https://smartbear.com/learn/code-review/best-practices-for-peer-code-review/