Looking to move to Continuous Delivery? Worried about the quality of your the code? Helping your developers understand clean-code practices and getting the right testing strategy in place can take a while. What should you do to control the quality of the incoming code till then? This talk shares our experience of using PRRiskAdvisor to gradually educate and influence developers to write better code and also help the code reviewer to be more effective at their reviews.  Every time a developer raises a pull-request, PRRiskAdvisor analyzes the files that were changed and publishes a report on the pull request itself with the overall risk associated with this pull request and also risk associated with each file. It also runs static code analysis using SonarQube and publishes the configured violations as comments on the pull request. This way the reviewer just has to look at the pull request to get a decent idea of what it means to review this pull request. If there are too many violations, then PRRiskAdvisor can also automatically reject the pull request. By doing this, we saw our developers starting paying more attention to clean code practices and hence the overall quality of the incoming code improved, while we worked on putting the right engineering practices and testing strategy in place. More details: https://confengine.com/last-conference-canberra-2018/proposal/7294/improving-the-quality-of-incoming-code Conference Link: https://2019.agileindia.org

1. Improving the Quality
of Incoming Code
Naresh Jain
@nashjain
naresh@xnsio.com
https://xnsio.com

3. Value Delivery Delays

4. Stress and Burn-out

5. Frustration

6. Erosion of Trust

7. TESTING STRATEGY
Unit
Tests
Integration
Tests
End-to-End
GUI Tests 80-90%
5-15%
1-5%
Manual Checking

8. Typical Approaches

9. Class room trainings

10. Automated xUnit Testing

15. Army of Testers

16. Licensed Under Creative Commons by Naresh Jain
S TAT I C C O D E A N A LY S I S

17. Problems with this approach

18. Unit testing and static code analysis
in isolation does not help!

19. Lack of Instant Gratification
It takes time to see the value

20. The output from sonarqube can be
overwhelming and not actionable

22. Possible Alternative

23. Commercial Break!

24. Copyright
© 2012,

25. Mumbai

30. Tech Talks!

34. Possible Alternative

35. I M P R O V I N G Q U A L I T Y O F C O D E R E V I E W S

36. I M P R O V I N G Q U A L I T Y O F C O D E R E V I E W S

37. I M P R O V I N G Q U A L I T Y O F C O D E R E V I E W S

38. I M P R O V I N G Q U A L I T Y O F C O D E R E V I E W S

39. I M P R O V I N G Q U A L I T Y O F C O D E R E V I E W S

41. How do you deal with
legacy code?

42. V I S U A L I S I N G C O D E H E A LT H U S I N G C 3

43. Diffy

44. Diffy

45. TESTING STRATEGY
Unit
Tests
Integration
Tests
End-to-End
GUI Tests 80-90%
5-15%
1-5%
Manual Checking

46. Unit Tests
Component / Service (API) Tests
Integration Tests
Acceptance Tests
Workflow
Tests
GUI
Tests
1%
70%
10%
9%
6%
4%
Performance Tests
Security Tests
Epic Level
Story Level
3rd Party/Device Dependencies
Exploratory Testing
% of Tests

47. User InputValidation, JSON Parsing
OnboardingActivity
Sinch Integration
Signup using Flash Call
Happy Path
Signup Flow
Verify
Welcome
Screen
Elements
1%
70%
10%
9%
6%
4%
Workflow Tests
Acceptance Tests
Integration Tests
Exploratory Testing
GUI Tests
Component / Service (API) Tests
Unit Tests

48. jUnit, XCTest, Mockito, OCMock, RoboElectric
jUnit, XCTest (Instrumented/In-Container) Tests
jUnit, XCTest
Cucumber,Appium
Cucumber,
Appium
Cucumber,
Appium
1%
70%
10%
9%
6%
4%
Workflow Tests
Acceptance Tests
Integration Tests
Exploratory Testing
GUI Tests
Component / Service (API) Tests
Unit Tests

50. Build/Release Infra
Code a
Feature
Run Static
Analysis
Run Unit &
Component Tests
Run Functional Tests
for my Feature
Local Dev
Raise a PR
Static Analysis
on Change-set
Run All
Unit Tests
Code
Review
C O N T I N U O U S I N T E G R AT I O N

51. Build/Release Infra
Build
Mainline
Run Component &
Sanity Tests on
Instrumented Code
Run Workflow Tests on
Instrumented Code
Code a
Feature
Run Static
Analysis
Run Unit &
Component Tests
Run Functional Tests
for my Feature
Local Dev
Raise a PR
Merge
Static Analysis
on Change-set
Run All
Unit Tests
Code
Review
C O N T I N U O U S I N T E G R AT I O N

52. Build/Release Infra
Build
Mainline
Run Component &
Sanity Tests on
Instrumented Code
Run Workflow Tests on
Instrumented Code
Code a
Feature
Run Static
Analysis
Run Unit &
Component Tests
Run Functional Tests
for my Feature
Local Dev
Raise a PR
Merge
Full
Regression
Full Static
Code Analysis
Benchmark, Perf
Tests & Dynamic
Analysis
Nightly Build
Static Analysis
on Change-set
Run All
Unit Tests
Code
Review
C O N T I N U O U S I N T E G R AT I O N

53. Build/Release Infra
Build
Mainline
Run Component &
Sanity Tests on
Instrumented Code
Run Workflow Tests on
Instrumented Code
Code a
Feature
Run Static
Analysis
Run Unit &
Component Tests
Run Functional Tests
for my Feature
Local Dev
Raise a PR
Consumable
Certified
Artifact
Merge
Full
Regression
Full Static
Code Analysis
Benchmark, Perf
Tests & Dynamic
Analysis
Nightly Build
Static Analysis
on Change-set
Run All
Unit Tests
Code
Review
C O N T I N U O U S I N T E G R AT I O N

54. T H A N K Y O U !
Q U E S T I O N S ?
Naresh Jain
@nashjain
naresh@xnsio.com
https://xnsio.com