Talk given during Coolblue Behind the Scenes on July 19th 2016, explaining what code review is, how to improve the quality of your reviews and what Coolblue learned while scaling this process up to 150 developers.

4. • Burgers
• “Scaling our Code Reviewing” - Sander Bol
• Short break
• “What's new in PHP 7?” - Thijs Feryn
• Office tour
• Drinks
Schedule

5. Facts

6. Facts

7. Facts

8. Facts

9. Facts

10. July 19th 2016 - Behind the Scenes
Sander Bol

12. Growth

13. Definition
Code Review is the act of
consciously and systematically
convening with one’s fellow programmers
to check each other’s code for mistakes
Source: https://smartbear.com/learn/code-review/what-is-code-review/

14. Code Review is the act of
consciously and systematically
convening with one’s fellow programmers
to check each other’s code for mistakes
Definition

15. Definition
Code Review is the act of
consciously and systematically
convening with one’s fellow programmers
to check each other’s code for mistakes

16. Definition
Code Review is the act of
consciously and systematically
convening with one’s fellow programmers
to check each other’s code for mistakes

17. Definition

18. Definition

19. Happy accidents?

20. Common mistakes

21. What to look for in a review?
● Functionality
● Design
● Readability & Maintainability
● Have you thought about…?

22. How you should do reviews...
_(ツ)_/¯

23. Answer me these questions three...
When
to review?
What
to review?
Who
is reviewing?

24. Pull Request Review
Production
Development

25. Post-merge Review
Production
Development

26. What to review

27. What to review

28. What to review

29. Who is reviewing?
?
? X
?
✓
✓
!!
X
✓

30. Who is reviewing?
?
? X
?
✓
✓
!!
X
✓
Indenting!
Whitespace!
Trailing comma!
Bad naming!
Low test coverage!
Debug code!
Insecure code!
Does not compile!

31. Who is reviewing?
?
✓ !!
X
✓
Indenting!
Whitespace!
Trailing comma!
Bad naming!
Low test coverage!
Debug code!
Insecure code!
Does not compile!

32. Answer me these questions three...
When
to review?
What
to review?
Who
is reviewing?

33. Asking for a review
- Start with the obvious
“The goal of my change is...”
- Limit size of change set
- Reserve time in advance
- Implement any feedback you receive (or explain why not)
- Keep your commits clean
- All tests green!

34. 3 steps Coolblue took

35. 3 steps Coolblue took

36. 3 steps Coolblue took

37. Tooling
Basic
● Pull request (Github / Bitbucket)
Advanced
● Jetbrains Upsource
● Phabricator Differential
● Reviewable.io (“Github reviews done right”)
● Atlassian Crucible

38. Remember, remember
1.Start with the obvious.
2.Automate the tedious.
3.Why so serious?

41. • Burgers
• “Scaling our Code Reviewing” - Sander Bol
• Short break
• “What's new in PHP 7?” - Thijs Feryn
• Office tour
• Drinks
Schedule

43. Untitled Bob Ross painting.
Image credits
http://dogtalk101.blogspot.nl/2011/05/let-sleeping-dogs-lie.html